Skip to content

Add test of coldboot passthrough behavior#1048

Open
zancas wants to merge 12 commits intodevfrom
db_hole_1047
Open

Add test of coldboot passthrough behavior#1048
zancas wants to merge 12 commits intodevfrom
db_hole_1047

Conversation

@zancas
Copy link
Copy Markdown
Member

@zancas zancas commented Apr 24, 2026

Adds test for #1047

@zancas zancas requested a review from AloeareV April 24, 2026 20:22
…lassification

When snapshot_nonfinalized_state() returns StillSyncingFinalizedState,
best_chaintip passes through `source.get_block(Height(validator_finalized_height))`
and emits `database_hole` on Ok(None) — categorising a transient
validator-side miss as zaino-owned corruption.

Adds a regression test that synthesizes that branch by claiming a
validator_finalized_height above the mockchain tip and asserts the
resulting error is not a database_hole. Fails today; pins the correct
behaviour once the fix lands.

Refs #1047.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zancas zancas marked this pull request as ready for review April 27, 2026 16:33
@zancas zancas changed the title Db hole 1047 Add test of coldboot passthrough behavior Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants